Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: Use the new way to handle the DDL operations #3367

Merged
merged 7 commits into from
Jun 1, 2017

Conversation

zimulala
Copy link
Contributor

@zimulala zimulala commented Jun 1, 2017

Remove the old code.

@hanfei1991
Copy link
Member

LGTM

store/tikv/kv.go Outdated
@@ -151,7 +151,7 @@ func NewMockTikvStoreWithCluster(cluster *mocktikv.Cluster) (kv.Storage, error)
mocktikv.BootstrapWithSingleStore(cluster)
mvccStore := mocktikv.NewMvccStore()
client := mocktikv.NewRPCClient(cluster, mvccStore)
uuid := fmt.Sprintf("mock-tikv-store-:%v", time.Now().Unix())
uuid := fmt.Sprintf("mock-tikv-store-%v-%v", time.Now().Unix(), rand.Intn(10))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

increase it

@hanfei1991 hanfei1991 added the status/LGT1 Indicates that a PR has LGTM 1. label Jun 1, 2017
@zimulala
Copy link
Contributor Author

zimulala commented Jun 1, 2017

PTAL @tiancaiamao @coocood @shenli

@zimulala zimulala added the priority/P1 The issue has P1 priority. label Jun 1, 2017
@zimulala zimulala added this to the rc3 milestone Jun 1, 2017
@coocood
Copy link
Member

coocood commented Jun 1, 2017

LGTM

@coocood coocood merged commit 6935e17 into zimuxia/mock-etcd-worker Jun 1, 2017
@zimulala zimulala deleted the zimuxia/ddl-new-way branch June 11, 2017 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority/P1 The issue has P1 priority. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants